Compare commits
19 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 3aec0b84fe | |||
| bd1d3bde7c | |||
| 998471f6df | |||
| 1f9b1ecd30 | |||
| 1d71617f71 | |||
| d18fc2470b | |||
| f29696607a | |||
| a75318b811 | |||
| 20b9eb0fc9 | |||
| 17bc0ed680 | |||
| 5020fdcc19 | |||
| 885f6c2b01 | |||
| 2aff6287d2 | |||
| 3364a50c68 | |||
| 936828abae | |||
| ab7a964934 | |||
| 649fcc711c | |||
| 3b62f61288 | |||
| ba36e3ff4c |
+45
-13
@@ -5,6 +5,10 @@ on:
|
||||
branches: [main]
|
||||
pull_request:
|
||||
|
||||
env:
|
||||
GO_VERSION: "1.23.12"
|
||||
GOPROXY: "https://goproxy.cn,direct"
|
||||
|
||||
jobs:
|
||||
go:
|
||||
name: Go (api)
|
||||
@@ -25,11 +29,22 @@ jobs:
|
||||
env:
|
||||
OPENGOODS_DATABASE_URL: postgres://opengoods:opengoods@postgres:5432/opengoods?sslmode=disable
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/setup-go@v5
|
||||
with:
|
||||
go-version: "1.23"
|
||||
cache-dependency-path: api/go.sum
|
||||
- name: Checkout
|
||||
working-directory: ${{ github.workspace }}
|
||||
run: |
|
||||
git config --global --add safe.directory '*'
|
||||
git init -q .
|
||||
git remote add origin "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git"
|
||||
git -c protocol.version=2 fetch -q --no-tags --depth 1 origin "${GITHUB_REF}"
|
||||
git checkout -q --force FETCH_HEAD
|
||||
- name: Setup Go
|
||||
working-directory: ${{ github.workspace }}
|
||||
run: |
|
||||
curl -fsSL -o /tmp/go.tgz "https://mirrors.aliyun.com/golang/go${GO_VERSION}.linux-amd64.tar.gz"
|
||||
rm -rf /usr/local/go
|
||||
tar -C /usr/local -xzf /tmp/go.tgz
|
||||
echo "/usr/local/go/bin" >> "$GITHUB_PATH"
|
||||
echo "$HOME/go/bin" >> "$GITHUB_PATH"
|
||||
- name: Apply migrations
|
||||
working-directory: .
|
||||
run: |
|
||||
@@ -44,14 +59,20 @@ jobs:
|
||||
python:
|
||||
name: Python (ingestion)
|
||||
runs-on: ubuntu-latest
|
||||
container:
|
||||
image: nikolaik/python-nodejs:python3.12-nodejs20
|
||||
defaults:
|
||||
run:
|
||||
working-directory: ingestion
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/setup-python@v5
|
||||
with:
|
||||
python-version: "3.12"
|
||||
- name: Checkout
|
||||
working-directory: ${{ github.workspace }}
|
||||
run: |
|
||||
git config --global --add safe.directory '*'
|
||||
git init -q .
|
||||
git remote add origin "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git"
|
||||
git -c protocol.version=2 fetch -q --no-tags --depth 1 origin "${GITHUB_REF}"
|
||||
git checkout -q --force FETCH_HEAD
|
||||
- name: Install
|
||||
run: pip install -e ".[dev]"
|
||||
- name: Ruff lint
|
||||
@@ -77,10 +98,21 @@ jobs:
|
||||
env:
|
||||
DBURL: postgres://opengoods:opengoods@postgres:5432/opengoods?sslmode=disable
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/setup-go@v5
|
||||
with:
|
||||
go-version: "1.23"
|
||||
- name: Checkout
|
||||
working-directory: ${{ github.workspace }}
|
||||
run: |
|
||||
git config --global --add safe.directory '*'
|
||||
git init -q .
|
||||
git remote add origin "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git"
|
||||
git -c protocol.version=2 fetch -q --no-tags --depth 1 origin "${GITHUB_REF}"
|
||||
git checkout -q --force FETCH_HEAD
|
||||
- name: Setup Go
|
||||
run: |
|
||||
curl -fsSL -o /tmp/go.tgz "https://mirrors.aliyun.com/golang/go${GO_VERSION}.linux-amd64.tar.gz"
|
||||
rm -rf /usr/local/go
|
||||
tar -C /usr/local -xzf /tmp/go.tgz
|
||||
echo "/usr/local/go/bin" >> "$GITHUB_PATH"
|
||||
echo "$HOME/go/bin" >> "$GITHUB_PATH"
|
||||
- name: Install golang-migrate
|
||||
run: go install -tags 'postgres' github.com/golang-migrate/migrate/v4/cmd/migrate@v4.18.1
|
||||
- name: Migrate up
|
||||
|
||||
@@ -9,6 +9,7 @@ import (
|
||||
|
||||
"github.com/jackc/pgx/v5/pgxpool"
|
||||
|
||||
"github.com/baicai2026-baicai/goods/api/internal/cache"
|
||||
"github.com/baicai2026-baicai/goods/api/internal/config"
|
||||
"github.com/baicai2026-baicai/goods/api/internal/handler"
|
||||
"github.com/baicai2026-baicai/goods/api/internal/publicweb"
|
||||
@@ -36,7 +37,12 @@ func main() {
|
||||
if !limiter.Enabled() {
|
||||
log.Print("warning: Redis not configured; public API rate limiting disabled")
|
||||
}
|
||||
h := handler.New(store.New(pool), publicweb.Dist()).
|
||||
|
||||
readCache := cache.New(cfg.RedisURL)
|
||||
if !readCache.Enabled() {
|
||||
log.Print("warning: Redis not configured; public API read cache disabled")
|
||||
}
|
||||
h := handler.New(store.New(pool).WithCache(readCache), publicweb.Dist()).
|
||||
WithRateLimit(limiter, cfg.AnonRateLimitPerMin).
|
||||
WithQuotas(cfg.AnonTotalQuota, cfg.RegisteredRateLimitPerMin, cfg.RegisteredQuotaTotal)
|
||||
|
||||
|
||||
@@ -31,6 +31,7 @@ type SubmissionInput struct {
|
||||
CountryOfOrigin *string `json:"country_of_origin"`
|
||||
IngredientsText *string `json:"ingredients_text"`
|
||||
Nutriments map[string]any `json:"nutriments"`
|
||||
Attributes map[string]any `json:"attributes"`
|
||||
NutritionBasis *string `json:"nutrition_basis"`
|
||||
ServingSize *string `json:"serving_size"`
|
||||
NutriScore *string `json:"nutri_score"`
|
||||
@@ -278,14 +279,19 @@ func (s *Store) ApproveSubmission(ctx context.Context, id, actor string) (*Produ
|
||||
|
||||
fields := submissionFields(in)
|
||||
|
||||
var attrJSON []byte
|
||||
if len(in.Attributes) > 0 {
|
||||
attrJSON, _ = json.Marshal(in.Attributes)
|
||||
}
|
||||
|
||||
if productID == "" {
|
||||
// Create a new product from the contribution.
|
||||
err = tx.QueryRow(ctx, `
|
||||
INSERT INTO product (gtin, name, brand_id, category_id, gpc_brick_code,
|
||||
net_content_value, net_content_unit, net_content_canonical, country_of_origin, status)
|
||||
VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,'active') RETURNING id`,
|
||||
net_content_value, net_content_unit, net_content_canonical, country_of_origin, attributes, status)
|
||||
VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,COALESCE($10::jsonb,'{}'::jsonb),'active') RETURNING id`,
|
||||
in.GTIN, in.Name, brandID, in.CategoryID, gpc,
|
||||
in.NetContentValue, in.NetContentUnit, canonical, in.CountryOfOrigin).Scan(&productID)
|
||||
in.NetContentValue, in.NetContentUnit, canonical, in.CountryOfOrigin, attrJSON).Scan(&productID)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
@@ -302,21 +308,29 @@ UPDATE product SET
|
||||
net_content_unit=COALESCE($7, net_content_unit),
|
||||
net_content_canonical=COALESCE($8, net_content_canonical),
|
||||
country_of_origin=COALESCE($9, country_of_origin),
|
||||
gtin=COALESCE($10, gtin)
|
||||
gtin=COALESCE($10, gtin),
|
||||
attributes=product.attributes || COALESCE($11::jsonb,'{}'::jsonb)
|
||||
WHERE id=$1`,
|
||||
productID, in.Name, brandID, in.CategoryID, gpc,
|
||||
in.NetContentValue, in.NetContentUnit, canonical, in.CountryOfOrigin, in.GTIN)
|
||||
in.NetContentValue, in.NetContentUnit, canonical, in.CountryOfOrigin, in.GTIN, attrJSON)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
}
|
||||
|
||||
// food_detail: upsert, preserving existing values where not provided.
|
||||
// food_detail: upsert only when the contribution carries food data, so a
|
||||
// non-food submission (drug/3C/generic) doesn't create an empty row.
|
||||
var nutriJSON []byte
|
||||
if len(in.Nutriments) > 0 {
|
||||
nutriJSON, _ = json.Marshal(in.Nutriments)
|
||||
}
|
||||
_, err = tx.Exec(ctx, `
|
||||
foodPresent := len(in.Nutriments) > 0 ||
|
||||
(in.IngredientsText != nil && *in.IngredientsText != "") ||
|
||||
(in.NutritionBasis != nil && *in.NutritionBasis != "") ||
|
||||
(in.ServingSize != nil && *in.ServingSize != "") ||
|
||||
(in.NutriScore != nil && *in.NutriScore != "")
|
||||
if foodPresent {
|
||||
_, err = tx.Exec(ctx, `
|
||||
INSERT INTO food_detail (product_id, ingredients_text, nutriments, nutrition_basis, serving_size, nutri_score)
|
||||
VALUES ($1,$2,$3,$4,$5,$6)
|
||||
ON CONFLICT (product_id) DO UPDATE SET
|
||||
@@ -325,9 +339,10 @@ ON CONFLICT (product_id) DO UPDATE SET
|
||||
nutrition_basis=COALESCE(EXCLUDED.nutrition_basis, food_detail.nutrition_basis),
|
||||
serving_size=COALESCE(EXCLUDED.serving_size, food_detail.serving_size),
|
||||
nutri_score=COALESCE(EXCLUDED.nutri_score, food_detail.nutri_score)`,
|
||||
productID, in.IngredientsText, nutriJSON, in.NutritionBasis, in.ServingSize, in.NutriScore)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
productID, in.IngredientsText, nutriJSON, in.NutritionBasis, in.ServingSize, in.NutriScore)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
}
|
||||
|
||||
for _, im := range in.Images {
|
||||
@@ -417,5 +432,14 @@ func submissionFields(in SubmissionInput) []string {
|
||||
add("ingredients", in.IngredientsText != nil && *in.IngredientsText != "")
|
||||
add("nutriments", len(in.Nutriments) > 0)
|
||||
add("image", len(in.Images) > 0)
|
||||
for k, v := range in.Attributes {
|
||||
if v == nil {
|
||||
continue
|
||||
}
|
||||
if s, ok := v.(string); ok && s == "" {
|
||||
continue
|
||||
}
|
||||
fields = append(fields, k)
|
||||
}
|
||||
return fields
|
||||
}
|
||||
|
||||
Vendored
+126
@@ -0,0 +1,126 @@
|
||||
// Package cache is a Redis-backed, fail-open read cache for the public API.
|
||||
//
|
||||
// It caches hot product details and search results so repeated reads avoid
|
||||
// PostgreSQL. Like the ratelimit package, every operation fails open: if Redis
|
||||
// is unavailable or misconfigured the caller simply falls back to the database,
|
||||
// so the cache can never take the API down or serve stale data after Redis loss.
|
||||
//
|
||||
// Invalidation is global and O(1): keys are namespaced by an epoch counter
|
||||
// stored in Redis (og:cache:epoch). The Python ingestion bumps that counter
|
||||
// after a write run, which logically invalidates every cached entry at once
|
||||
// while old keys age out via their TTL. The epoch is read at most once per
|
||||
// refresh interval per process, so it adds no per-request round trip.
|
||||
package cache
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"log"
|
||||
"strconv"
|
||||
"sync"
|
||||
"time"
|
||||
|
||||
"github.com/redis/go-redis/v9"
|
||||
)
|
||||
|
||||
// epochKey is the Redis key holding the global cache generation counter.
|
||||
const epochKey = "og:cache:epoch"
|
||||
|
||||
// epochRefresh bounds how often a process re-reads the epoch from Redis.
|
||||
const epochRefresh = 10 * time.Second
|
||||
|
||||
// opTimeout caps any single Redis operation so a slow backend never blocks a
|
||||
// request beyond this; on timeout the cache fails open.
|
||||
const opTimeout = 150 * time.Millisecond
|
||||
|
||||
// Cache wraps a Redis client. A nil-backed Cache (Redis unconfigured) disables
|
||||
// caching: every Get misses and every Set is a no-op.
|
||||
type Cache struct {
|
||||
rdb *redis.Client
|
||||
|
||||
mu sync.RWMutex
|
||||
epoch int64
|
||||
epochSetAt time.Time
|
||||
epochOK bool
|
||||
}
|
||||
|
||||
// New builds a Cache from a redis:// URL. On a parse error it logs and returns a
|
||||
// disabled (fail-open) cache so the server still boots.
|
||||
func New(redisURL string) *Cache {
|
||||
opt, err := redis.ParseURL(redisURL)
|
||||
if err != nil {
|
||||
log.Printf("cache: invalid redis url %q: %v (caching disabled)", redisURL, err)
|
||||
return &Cache{}
|
||||
}
|
||||
return &Cache{rdb: redis.NewClient(opt)}
|
||||
}
|
||||
|
||||
// Enabled reports whether a Redis backend is configured.
|
||||
func (c *Cache) Enabled() bool { return c != nil && c.rdb != nil }
|
||||
|
||||
// epochNow returns the current cache generation, reading it from Redis at most
|
||||
// once per epochRefresh. On any Redis error it keeps the last known value and
|
||||
// throttles re-reads so a down backend cannot slow the hot path.
|
||||
func (c *Cache) epochNow(ctx context.Context) int64 {
|
||||
c.mu.RLock()
|
||||
if c.epochOK && time.Since(c.epochSetAt) < epochRefresh {
|
||||
e := c.epoch
|
||||
c.mu.RUnlock()
|
||||
return e
|
||||
}
|
||||
c.mu.RUnlock()
|
||||
|
||||
cctx, cancel := context.WithTimeout(ctx, opTimeout)
|
||||
defer cancel()
|
||||
n, err := c.rdb.Get(cctx, epochKey).Int64()
|
||||
|
||||
c.mu.Lock()
|
||||
defer c.mu.Unlock()
|
||||
switch {
|
||||
case err == nil:
|
||||
c.epoch = n
|
||||
case errors.Is(err, redis.Nil):
|
||||
c.epoch = 0
|
||||
}
|
||||
c.epochSetAt = time.Now()
|
||||
c.epochOK = true
|
||||
return c.epoch
|
||||
}
|
||||
|
||||
// key namespaces a logical suffix under the current epoch.
|
||||
func (c *Cache) key(ctx context.Context, suffix string) string {
|
||||
return "og:v" + strconv.FormatInt(c.epochNow(ctx), 10) + ":" + suffix
|
||||
}
|
||||
|
||||
// GetJSON unmarshals the cached value for suffix into dest and reports a hit.
|
||||
// Any miss, decode error, or Redis error returns false (fail-open).
|
||||
func (c *Cache) GetJSON(ctx context.Context, suffix string, dest any) bool {
|
||||
if !c.Enabled() {
|
||||
return false
|
||||
}
|
||||
k := c.key(ctx, suffix)
|
||||
cctx, cancel := context.WithTimeout(ctx, opTimeout)
|
||||
defer cancel()
|
||||
b, err := c.rdb.Get(cctx, k).Bytes()
|
||||
if err != nil {
|
||||
return false
|
||||
}
|
||||
return json.Unmarshal(b, dest) == nil
|
||||
}
|
||||
|
||||
// SetJSON stores val (JSON-encoded) for suffix with the given TTL. Best effort:
|
||||
// marshal or Redis errors are ignored.
|
||||
func (c *Cache) SetJSON(ctx context.Context, suffix string, val any, ttl time.Duration) {
|
||||
if !c.Enabled() {
|
||||
return
|
||||
}
|
||||
b, err := json.Marshal(val)
|
||||
if err != nil {
|
||||
return
|
||||
}
|
||||
k := c.key(ctx, suffix)
|
||||
cctx, cancel := context.WithTimeout(ctx, opTimeout)
|
||||
defer cancel()
|
||||
_ = c.rdb.Set(cctx, k, b, ttl).Err()
|
||||
}
|
||||
Vendored
+84
@@ -0,0 +1,84 @@
|
||||
package cache
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"os"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// TestDisabledFailsOpen verifies a Cache without a Redis backend never panics,
|
||||
// always misses, and silently drops writes.
|
||||
func TestDisabledFailsOpen(t *testing.T) {
|
||||
c := New("not-a-valid-url") // parse error => disabled
|
||||
if c.Enabled() {
|
||||
t.Fatal("expected cache to be disabled for invalid url")
|
||||
}
|
||||
c.SetJSON(context.Background(), "k", map[string]int{"a": 1}, time.Minute)
|
||||
var dst map[string]int
|
||||
if c.GetJSON(context.Background(), "k", &dst) {
|
||||
t.Fatalf("disabled cache must always miss, got %+v", dst)
|
||||
}
|
||||
}
|
||||
|
||||
func testCache(t *testing.T) *Cache {
|
||||
t.Helper()
|
||||
url := os.Getenv("OPENGOODS_REDIS_URL")
|
||||
if url == "" {
|
||||
url = "redis://localhost:6379/0"
|
||||
}
|
||||
c := New(url)
|
||||
if !c.Enabled() {
|
||||
t.Skip("redis not configured")
|
||||
}
|
||||
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
|
||||
defer cancel()
|
||||
if err := c.rdb.Ping(ctx).Err(); err != nil {
|
||||
t.Skipf("redis not reachable: %v", err)
|
||||
}
|
||||
return c
|
||||
}
|
||||
|
||||
// TestRoundTrip stores then reads a value back.
|
||||
func TestRoundTrip(t *testing.T) {
|
||||
c := testCache(t)
|
||||
ctx := context.Background()
|
||||
suffix := fmt.Sprintf("test:rt:%d", time.Now().UnixNano())
|
||||
|
||||
c.SetJSON(ctx, suffix, map[string]any{"name": "foo", "n": float64(3)}, time.Minute)
|
||||
got := map[string]any{}
|
||||
if !c.GetJSON(ctx, suffix, &got) {
|
||||
t.Fatal("expected cache hit after set")
|
||||
}
|
||||
if got["name"] != "foo" || got["n"] != float64(3) {
|
||||
t.Fatalf("unexpected payload: %+v", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestEpochInvalidation verifies that bumping the epoch counter logically drops
|
||||
// every previously cached entry.
|
||||
func TestEpochInvalidation(t *testing.T) {
|
||||
c := testCache(t)
|
||||
ctx := context.Background()
|
||||
suffix := fmt.Sprintf("test:epoch:%d", time.Now().UnixNano())
|
||||
|
||||
c.SetJSON(ctx, suffix, map[string]int{"v": 1}, time.Minute)
|
||||
var dst map[string]int
|
||||
if !c.GetJSON(ctx, suffix, &dst) {
|
||||
t.Fatal("expected hit before epoch bump")
|
||||
}
|
||||
|
||||
// Simulate an ingestion write bumping the global epoch.
|
||||
if err := c.rdb.Incr(ctx, epochKey).Err(); err != nil {
|
||||
t.Fatalf("incr epoch: %v", err)
|
||||
}
|
||||
// Force the process to re-read the epoch rather than use its cached value.
|
||||
c.mu.Lock()
|
||||
c.epochOK = false
|
||||
c.mu.Unlock()
|
||||
|
||||
if c.GetJSON(ctx, suffix, &dst) {
|
||||
t.Fatal("entry should be invisible after epoch bump")
|
||||
}
|
||||
}
|
||||
@@ -127,6 +127,7 @@ func (h *Handler) Router() http.Handler {
|
||||
})
|
||||
r.Get("/brands", h.ListBrands)
|
||||
r.Get("/categories", h.ListCategories)
|
||||
r.Get("/kind-fields", h.ListKindFields)
|
||||
r.Get("/sources/{id}", h.SourceByID)
|
||||
r.Get("/stats", h.Stats)
|
||||
})
|
||||
@@ -275,6 +276,21 @@ func (h *Handler) ListCategories(w http.ResponseWriter, r *http.Request) {
|
||||
writeJSON(w, http.StatusOK, map[string]any{"items": items})
|
||||
}
|
||||
|
||||
// ListKindFields returns the read-only spec field template for an archive kind,
|
||||
// used by the contribution form to render kind-specific inputs.
|
||||
func (h *Handler) ListKindFields(w http.ResponseWriter, r *http.Request) {
|
||||
kind := strings.TrimSpace(r.URL.Query().Get("kind"))
|
||||
if kind == "" {
|
||||
writeError(w, r, http.StatusBadRequest, "bad_request", "missing kind")
|
||||
return
|
||||
}
|
||||
items, err := h.store.ListKindFields(r.Context(), kind)
|
||||
if h.handleErr(w, r, err) {
|
||||
return
|
||||
}
|
||||
writeJSON(w, http.StatusOK, map[string]any{"items": items, "kind": kind})
|
||||
}
|
||||
|
||||
// SourceByID returns a single data source.
|
||||
func (h *Handler) SourceByID(w http.ResponseWriter, r *http.Request) {
|
||||
src, err := h.store.SourceByID(r.Context(), chi.URLParam(r, "id"))
|
||||
|
||||
+119
-5
@@ -4,21 +4,35 @@ package store
|
||||
|
||||
import (
|
||||
"context"
|
||||
"crypto/sha1"
|
||||
"encoding/hex"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/jackc/pgx/v5"
|
||||
"github.com/jackc/pgx/v5/pgxpool"
|
||||
|
||||
"github.com/baicai2026-baicai/goods/api/internal/cache"
|
||||
)
|
||||
|
||||
// Cache TTLs for the public read cache. Product details are far less volatile
|
||||
// than search result sets, so they live longer; both are also invalidated
|
||||
// wholesale whenever ingestion bumps the cache epoch.
|
||||
const (
|
||||
productCacheTTL = 24 * time.Hour
|
||||
searchCacheTTL = time.Hour
|
||||
)
|
||||
|
||||
// ErrNotFound is returned when a requested row does not exist.
|
||||
var ErrNotFound = errors.New("not found")
|
||||
|
||||
// Store wraps a PostgreSQL connection pool.
|
||||
// Store wraps a PostgreSQL connection pool and an optional read cache.
|
||||
type Store struct {
|
||||
pool *pgxpool.Pool
|
||||
pool *pgxpool.Pool
|
||||
cache *cache.Cache
|
||||
}
|
||||
|
||||
// New constructs a Store from an existing pgx pool.
|
||||
@@ -26,6 +40,30 @@ func New(pool *pgxpool.Pool) *Store {
|
||||
return &Store{pool: pool}
|
||||
}
|
||||
|
||||
// WithCache attaches a Redis-backed read cache. A nil or disabled cache leaves
|
||||
// the Store reading straight from PostgreSQL.
|
||||
func (s *Store) WithCache(c *cache.Cache) *Store {
|
||||
s.cache = c
|
||||
return s
|
||||
}
|
||||
|
||||
// cacheGet reads a cached JSON value into dest, reporting a hit. It is a no-op
|
||||
// miss when no cache is attached.
|
||||
func (s *Store) cacheGet(ctx context.Context, suffix string, dest any) bool {
|
||||
if s.cache == nil {
|
||||
return false
|
||||
}
|
||||
return s.cache.GetJSON(ctx, suffix, dest)
|
||||
}
|
||||
|
||||
// cacheSet stores a JSON value when a cache is attached.
|
||||
func (s *Store) cacheSet(ctx context.Context, suffix string, val any, ttl time.Duration) {
|
||||
if s.cache == nil {
|
||||
return
|
||||
}
|
||||
s.cache.SetJSON(ctx, suffix, val, ttl)
|
||||
}
|
||||
|
||||
// Ping verifies database connectivity.
|
||||
func (s *Store) Ping(ctx context.Context) error {
|
||||
return s.pool.Ping(ctx)
|
||||
@@ -222,6 +260,10 @@ func stringifyAttr(v any) string {
|
||||
|
||||
// ProductByGTIN looks up an active product by any of its barcodes.
|
||||
func (s *Store) ProductByGTIN(ctx context.Context, gtin string) (*Product, error) {
|
||||
const suffix = "prod:gtin:"
|
||||
if cached := new(Product); s.cacheGet(ctx, suffix+gtin, cached) {
|
||||
return cached, nil
|
||||
}
|
||||
row := s.pool.QueryRow(ctx, productSelect+`
|
||||
WHERE p.status = 'active'
|
||||
AND (p.gtin = $1 OR EXISTS (
|
||||
@@ -238,11 +280,16 @@ func (s *Store) ProductByGTIN(ctx context.Context, gtin string) (*Product, error
|
||||
if p.Specs, err = s.buildSpecs(ctx, p.ArchiveKind, attrs); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
s.cacheSet(ctx, suffix+gtin, p, productCacheTTL)
|
||||
return p, nil
|
||||
}
|
||||
|
||||
// ProductByID looks up a product by its UUID.
|
||||
func (s *Store) ProductByID(ctx context.Context, id string) (*Product, error) {
|
||||
const suffix = "prod:id:"
|
||||
if cached := new(Product); s.cacheGet(ctx, suffix+id, cached) {
|
||||
return cached, nil
|
||||
}
|
||||
row := s.pool.QueryRow(ctx, productSelect+" WHERE p.id = $1", id)
|
||||
p, attrs, err := scanProduct(row)
|
||||
if err != nil {
|
||||
@@ -254,6 +301,7 @@ func (s *Store) ProductByID(ctx context.Context, id string) (*Product, error) {
|
||||
if p.Specs, err = s.buildSpecs(ctx, p.ArchiveKind, attrs); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
s.cacheSet(ctx, suffix+id, p, productCacheTTL)
|
||||
return p, nil
|
||||
}
|
||||
|
||||
@@ -268,6 +316,11 @@ const fuzzyThreshold = "0.42"
|
||||
// similarity blended with quality_score so the best, most-complete records
|
||||
// surface first. Without a query, results are ordered by quality_score.
|
||||
func (s *Store) SearchProducts(ctx context.Context, f SearchFilters, limit, offset int) ([]ProductSummary, int, error) {
|
||||
suffix := searchCacheSuffix(f, limit, offset)
|
||||
if entry := new(searchCacheEntry); s.cacheGet(ctx, suffix, entry) {
|
||||
return entry.Items, entry.Total, nil
|
||||
}
|
||||
|
||||
args := []any{}
|
||||
where := "WHERE p.status = 'active'"
|
||||
|
||||
@@ -334,7 +387,28 @@ LEFT JOIN category c ON c.id = p.category_id `
|
||||
}
|
||||
out = append(out, ps)
|
||||
}
|
||||
return out, total, rows.Err()
|
||||
if err := rows.Err(); err != nil {
|
||||
return nil, 0, err
|
||||
}
|
||||
s.cacheSet(ctx, suffix, searchCacheEntry{Items: out, Total: total}, searchCacheTTL)
|
||||
return out, total, nil
|
||||
}
|
||||
|
||||
// searchCacheEntry is the cached payload for a SearchProducts call.
|
||||
type searchCacheEntry struct {
|
||||
Items []ProductSummary `json:"items"`
|
||||
Total int `json:"total"`
|
||||
}
|
||||
|
||||
// searchCacheSuffix derives a stable cache key from the full filter set and
|
||||
// paging window so distinct queries never collide.
|
||||
func searchCacheSuffix(f SearchFilters, limit, offset int) string {
|
||||
raw := strings.Join([]string{
|
||||
f.Query, f.Category, f.Brand, f.Country,
|
||||
strconv.Itoa(limit), strconv.Itoa(offset),
|
||||
}, "\x1f")
|
||||
sum := sha1.Sum([]byte(raw))
|
||||
return "search:" + hex.EncodeToString(sum[:])
|
||||
}
|
||||
|
||||
// Nutriments returns just the nutrition payload for a product.
|
||||
@@ -427,12 +501,13 @@ type Category struct {
|
||||
Path string `json:"path"`
|
||||
GPCBrickCode *string `json:"gpc_brick_code"`
|
||||
Level int `json:"level"`
|
||||
ArchiveKind string `json:"archive_kind"`
|
||||
}
|
||||
|
||||
// ListCategories returns the full category tree ordered by path.
|
||||
func (s *Store) ListCategories(ctx context.Context) ([]Category, error) {
|
||||
rows, err := s.pool.Query(ctx,
|
||||
"SELECT id, name_zh, name_en, path::text, gpc_brick_code, level FROM category ORDER BY path")
|
||||
"SELECT id, name_zh, name_en, path::text, gpc_brick_code, level, COALESCE(archive_kind, 'generic') FROM category ORDER BY path")
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
@@ -440,7 +515,7 @@ func (s *Store) ListCategories(ctx context.Context) ([]Category, error) {
|
||||
out := []Category{}
|
||||
for rows.Next() {
|
||||
var c Category
|
||||
if err := rows.Scan(&c.ID, &c.NameZH, &c.NameEN, &c.Path, &c.GPCBrickCode, &c.Level); err != nil {
|
||||
if err := rows.Scan(&c.ID, &c.NameZH, &c.NameEN, &c.Path, &c.GPCBrickCode, &c.Level, &c.ArchiveKind); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out = append(out, c)
|
||||
@@ -448,6 +523,45 @@ func (s *Store) ListCategories(ctx context.Context) ([]Category, error) {
|
||||
return out, rows.Err()
|
||||
}
|
||||
|
||||
// KindField describes one editable spec field for an archive kind. It drives
|
||||
// the dynamic contribution form (public, read-only view of the template).
|
||||
type KindField struct {
|
||||
Kind string `json:"kind"`
|
||||
FieldKey string `json:"field_key"`
|
||||
GroupLabel string `json:"group_label"`
|
||||
LabelZH string `json:"label_zh"`
|
||||
FieldType string `json:"field_type"`
|
||||
Unit *string `json:"unit"`
|
||||
Options []string `json:"options"`
|
||||
Placeholder *string `json:"placeholder"`
|
||||
SortOrder int `json:"sort_order"`
|
||||
Qualified bool `json:"qualified"`
|
||||
}
|
||||
|
||||
// ListKindFields returns the ordered field template for one archive kind so the
|
||||
// public contribution form can render kind-specific inputs.
|
||||
func (s *Store) ListKindFields(ctx context.Context, kind string) ([]KindField, error) {
|
||||
rows, err := s.pool.Query(ctx, `
|
||||
SELECT kind, field_key, group_label, label_zh, field_type, unit, options,
|
||||
placeholder, sort_order, qualified
|
||||
FROM kind_field WHERE kind = $1 ORDER BY sort_order, field_key`, kind)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
defer rows.Close()
|
||||
out := []KindField{}
|
||||
for rows.Next() {
|
||||
var f KindField
|
||||
if err := rows.Scan(&f.Kind, &f.FieldKey, &f.GroupLabel, &f.LabelZH,
|
||||
&f.FieldType, &f.Unit, &f.Options, &f.Placeholder, &f.SortOrder,
|
||||
&f.Qualified); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out = append(out, f)
|
||||
}
|
||||
return out, rows.Err()
|
||||
}
|
||||
|
||||
// APIKey is the minimal metadata the public API needs to authorize a caller.
|
||||
type APIKey struct {
|
||||
ID string
|
||||
|
||||
@@ -0,0 +1,112 @@
|
||||
# 可扩展性设计与路线图 (Scalability Roadmap)
|
||||
|
||||
本文档回答一个长期问题:随着商品越来越多、品类越来越杂(食品 / 电子 3C / 药品 /
|
||||
……),**检索与新增会不会压垮数据库?要不要按品类「分表」?**
|
||||
|
||||
> 结论先行:**现阶段不要按品类手动分表。** 现有「单表 + JSONB + archive_kind 框架」
|
||||
> 的设计方向是对的。扩展应当靠 **分区(非分表) + 读副本 + 缓存 + 专用搜索引擎**,
|
||||
> 按数据量分阶段推进,避免提前过度设计。
|
||||
|
||||
---
|
||||
|
||||
## 1. 现状盘点
|
||||
|
||||
### 1.1 数据模型
|
||||
- 所有商品落在**一张 `product` 表**;非食品的领域字段存 `product.attributes`(JSONB)。
|
||||
- 食品有独立明细表 `food_detail`(配料 / 营养 / 过敏原等结构化字段)。
|
||||
- `0010_archive_kinds` 引入 **archive_kind 框架**:每个品类带一个 `archive_kind`
|
||||
(`food` / `electronics` / `generic`),`kind_field` 表按 kind 定义字段模板,
|
||||
驱动后台动态表单与合格度评分。
|
||||
- **加新品类(如药品)不需要新建表**:只要新增一组 `kind_field` 行 + 一棵品类子树;
|
||||
仅当某品类有大量需被独立筛选/排序的结构化字段时,才考虑像 `food_detail` 那样补一张
|
||||
明细表。
|
||||
|
||||
### 1.2 已有索引(检索性能的基础)
|
||||
| 对象 | 索引 | 用途 |
|
||||
|------|------|------|
|
||||
| `product.gtin` | 唯一索引 | 条码精确查 |
|
||||
| `product.name` | trigram GIN (`pg_trgm`) | 名称模糊/相似匹配 |
|
||||
| `product.search_tsv` | 全文 GIN (`tsvector`) | 全文检索 |
|
||||
| `product.attributes` | JSONB GIN | 属性过滤 |
|
||||
| `brand.name` | trigram GIN | 品牌模糊匹配 |
|
||||
| `product.country_of_origin` | btree | 产地精确/前缀过滤 |
|
||||
| category / brand / updated_at | btree | 关联与增量 |
|
||||
|
||||
### 1.3 检索方式
|
||||
- 有关键词时:`name ILIKE` ∪ `word_similarity ≥ 阈值(~0.42)` ∪ 条码匹配,
|
||||
排序按 `相似度 × (0.5 + quality_score)`。
|
||||
- 无关键词时:按 `quality_score` 排序。
|
||||
- 翻页:`LIMIT / OFFSET`。
|
||||
|
||||
### 1.4 写入特征
|
||||
- 写库**只有** Python ingestion 一条路径(批量 ETL),不是高并发 OLTP。
|
||||
- 插入瓶颈极低;`search_tsv` 由触发器逐行重算,正常增量下开销可忽略。
|
||||
|
||||
---
|
||||
|
||||
## 2. 为什么不建议按品类「分表」
|
||||
|
||||
1. **核心场景是全局检索**:用户通常不知道商品属于哪个品类,搜索要跨所有品类。
|
||||
按品类拆成多表后,一次搜索得 `UNION ALL` 所有表,**更慢、代码更复杂、排序更难统一**。
|
||||
2. **单表足够能打**:Postgres 单表配好索引,**几千万行**量级的检索完全可承载。
|
||||
"表大"很少是真正瓶颈,"搜索方式"和"读并发"才是。
|
||||
3. **分表会侵蚀框架优势**:archive_kind 框架的价值就是"加品类零建表";手动分表等于
|
||||
把这套通用能力又拆碎。
|
||||
|
||||
> 区分两个概念:**分表(sharding,应用层拆多张表)** ≠ **分区(Postgres 原生
|
||||
> declarative partitioning,对上层透明的一张逻辑表)**。后者在超大规模时才有意义,
|
||||
> 见第 3 阶段。
|
||||
|
||||
---
|
||||
|
||||
## 3. 分阶段路线图(按数据量触发,不提前做)
|
||||
|
||||
### 阶段 0 — 现在 ~ 数百万条:维持现状 + 低成本优化
|
||||
触发:当前规模。改动小、收益稳,建议尽早做:
|
||||
- **深翻页改 keyset 分页**:`OFFSET` 越翻越慢(需扫描并丢弃前 N 行);改用
|
||||
`WHERE (score, id) < (:last_score, :last_id)` 形式的游标分页。
|
||||
- **部分索引**:绝大多数查询限定 `status='active'`,可建
|
||||
`CREATE INDEX ... WHERE status='active'` 缩小索引、提速。
|
||||
- **常用筛选复合索引**:如 `(category_id, quality_score DESC)`、
|
||||
`(archive_kind, quality_score DESC)` 配合域内列表。
|
||||
- **Redis 缓存**(已在技术栈内):缓存热门搜索结果与商品详情,挡住重复读。
|
||||
|
||||
### 阶段 1 — 千万级以上:读扩展 + 调优
|
||||
触发:单库读 QPS 升高、P99 变慢。
|
||||
- **只读副本(read replica)**:本服务是**只读公益 API**,天然适合一主多从,
|
||||
把检索/详情读流量分到副本,主库只承接 ingestion 写入。
|
||||
- **索引与查询调优**:按慢查询日志补/删索引,`EXPLAIN ANALYZE` 校核计划。
|
||||
- **(可选)Postgres 原生分区**:若多数检索"限定单一域"(只搜药品 / 只搜食品),
|
||||
可按 `archive_kind` 做 **LIST 分区**(对上层透明,仍是一张逻辑表)。主要利好
|
||||
**维护**(分区级 vacuum / 归档)与**域内查询裁剪**;对真正的全局搜索帮助有限。
|
||||
|
||||
### 阶段 2 — 搜索相关性/规模成为痛点:引入专用搜索引擎
|
||||
触发:`pg_trgm`/`tsvector` 在相关性排序、跨字段检索、规模上吃力。
|
||||
- 把**检索**迁到专用倒排引擎:**OpenSearch / Meilisearch / Typesense**,
|
||||
或 Postgres 内的 **ParadeDB(`pg_search`,BM25)**。
|
||||
- **Postgres 仍是唯一事实来源**;搜索引擎只做索引,由 ingestion 在写库后同步。
|
||||
- 这才是"搜索量大"的正解,**比分表有效得多**。
|
||||
|
||||
---
|
||||
|
||||
## 4. 大批量导入的建议
|
||||
- 海量初始化/回填用 `COPY` 而非逐行 `INSERT`。
|
||||
- 超大批量时可"先停建二级索引 → COPY → 重建索引",比边插边维护索引快得多。
|
||||
- ETL 控制并发与批大小,避免与在线读争抢。
|
||||
|
||||
---
|
||||
|
||||
## 5. 药品档案怎么落地(回到最初的问题)
|
||||
在上述设计下,加"药品"属于**阶段 0 的常规扩展**,不触动架构:
|
||||
1. 新增 `drug` 的 `kind_field` 模板(批准文号 / 通用名 / 商品名 / 剂型 / 规格 /
|
||||
生产企业 / OTC 分类 / 适应症 / 用法用量 / 不良反应 / 禁忌 / 注意事项 / 贮藏 /
|
||||
有效期 等),`qualified` 标记关键字段参与合格度评分。
|
||||
2. 加一棵药品品类子树,并把这些品类的 `archive_kind` 置为 `drug`。
|
||||
3. 仅当药品需要**被独立筛选/排序的强结构化字段**(如按批准文号精确查、按 OTC 分类
|
||||
过滤)时,才考虑补一张 `drug_detail` 明细表;否则继续走 `attributes` JSONB。
|
||||
|
||||
---
|
||||
|
||||
## 6. 版本
|
||||
- 本路线图随规模演进更新;任何落地改动需同步:迁移(SQL) + 本文档 +(涉及对外字段时)
|
||||
`docs/data-contract.md` / `docs/openapi.yaml`。
|
||||
@@ -0,0 +1,52 @@
|
||||
"""Read-cache invalidation signal for the public API.
|
||||
|
||||
The Go API caches hot product details and search results in Redis, namespacing
|
||||
every key by a global generation counter (``og:cache:epoch``). Bumping that
|
||||
counter logically invalidates the entire cache in one O(1) operation while the
|
||||
old keys age out via their TTL.
|
||||
|
||||
Ingestion is the only writer to the database, so after a run that changed data
|
||||
it calls :func:`bump_cache_epoch` to make those changes visible immediately
|
||||
instead of waiting for per-key TTLs to expire.
|
||||
|
||||
Like the API's cache, this is strictly best effort and fails open: if Redis is
|
||||
unconfigured or unreachable the ingestion run still succeeds, and stale entries
|
||||
simply expire on their own.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import logging
|
||||
import os
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
EPOCH_KEY = "og:cache:epoch"
|
||||
|
||||
|
||||
def default_redis_url() -> str | None:
|
||||
"""Return the configured Redis URL, or ``None`` when caching is disabled."""
|
||||
return os.environ.get("OPENGOODS_REDIS_URL") or None
|
||||
|
||||
|
||||
def bump_cache_epoch(url: str | None = None) -> bool:
|
||||
"""Increment the API cache generation counter.
|
||||
|
||||
Returns ``True`` if the counter was bumped, ``False`` if caching is disabled
|
||||
or Redis was unreachable. Never raises: invalidation failures must not fail
|
||||
an ingestion run.
|
||||
"""
|
||||
url = url or default_redis_url()
|
||||
if not url:
|
||||
return False
|
||||
try:
|
||||
import redis # imported lazily so the dependency is optional at runtime
|
||||
|
||||
client = redis.Redis.from_url(url, socket_timeout=2, socket_connect_timeout=2)
|
||||
new_epoch = client.incr(EPOCH_KEY)
|
||||
client.close()
|
||||
logger.info("bumped API cache epoch to %s", new_epoch)
|
||||
return True
|
||||
except Exception as exc: # noqa: BLE001 - invalidation is best effort
|
||||
logger.warning("cache epoch bump skipped: %s", exc)
|
||||
return False
|
||||
@@ -12,6 +12,7 @@ import sys
|
||||
|
||||
import psycopg
|
||||
|
||||
from opengoods.cache import bump_cache_epoch
|
||||
from opengoods.etl.dedup import dedup_all
|
||||
from opengoods.etl.load import default_dsn
|
||||
|
||||
@@ -23,6 +24,8 @@ def run(args: argparse.Namespace) -> int:
|
||||
conn.rollback()
|
||||
else:
|
||||
conn.commit()
|
||||
if not args.dry_run and summary["merged"]:
|
||||
bump_cache_epoch()
|
||||
mode = "dry-run" if args.dry_run else "applied"
|
||||
print(f"{mode} groups={summary['groups']} merged={summary['merged']}")
|
||||
return 0
|
||||
|
||||
@@ -25,6 +25,7 @@ from collections.abc import Iterator
|
||||
import psycopg
|
||||
|
||||
from opengoods.adapters.bypos import transform_bypos
|
||||
from opengoods.cache import bump_cache_epoch
|
||||
from opengoods.etl.load import default_dsn, ensure_bypos_source, load_bypos_record_safe
|
||||
|
||||
|
||||
@@ -59,6 +60,8 @@ def run(args: argparse.Namespace) -> int:
|
||||
else:
|
||||
errored += 1
|
||||
conn.commit()
|
||||
if loaded:
|
||||
bump_cache_epoch()
|
||||
print(f"loaded={loaded} skipped={skipped} errored={errored}")
|
||||
return 0
|
||||
|
||||
|
||||
@@ -28,6 +28,7 @@ from opengoods.adapters.openfoodfacts import (
|
||||
is_cn_gs1,
|
||||
read_dump,
|
||||
)
|
||||
from opengoods.cache import bump_cache_epoch
|
||||
from opengoods.etl.load import default_dsn, ensure_source, load_record_safe
|
||||
from opengoods.etl.transform import transform
|
||||
|
||||
@@ -67,6 +68,8 @@ def run(args: argparse.Namespace) -> int:
|
||||
else:
|
||||
errored += 1
|
||||
conn.commit()
|
||||
if loaded:
|
||||
bump_cache_epoch()
|
||||
print(f"loaded={loaded} skipped={skipped} errored={errored}")
|
||||
return 0
|
||||
|
||||
|
||||
@@ -17,6 +17,7 @@ import sys
|
||||
import psycopg
|
||||
|
||||
from opengoods.adapters.openfoodfacts import SOURCE_NAME, OpenFoodFactsAdapter
|
||||
from opengoods.cache import bump_cache_epoch
|
||||
from opengoods.etl.load import default_dsn, ensure_source, load_record_safe
|
||||
from opengoods.etl.state import get_watermark, set_watermark
|
||||
from opengoods.etl.transform import transform
|
||||
@@ -49,6 +50,8 @@ def run(args: argparse.Namespace) -> int:
|
||||
stats={"loaded": loaded, "skipped": skipped, "errored": errored, "since": since},
|
||||
)
|
||||
conn.commit()
|
||||
if loaded:
|
||||
bump_cache_epoch()
|
||||
print(
|
||||
f"since={since} loaded={loaded} skipped={skipped} "
|
||||
f"errored={errored} watermark={high_watermark}"
|
||||
|
||||
@@ -6,6 +6,7 @@ requires-python = ">=3.11"
|
||||
dependencies = [
|
||||
"httpx>=0.27",
|
||||
"psycopg[binary]>=3.2",
|
||||
"redis>=5.0,<6",
|
||||
]
|
||||
|
||||
[project.optional-dependencies]
|
||||
|
||||
@@ -0,0 +1,44 @@
|
||||
"""Tests for the best-effort API cache invalidation signal."""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import sys
|
||||
|
||||
import opengoods.cache as cache
|
||||
|
||||
|
||||
def test_disabled_when_no_url(monkeypatch):
|
||||
monkeypatch.delenv("OPENGOODS_REDIS_URL", raising=False)
|
||||
assert cache.default_redis_url() is None
|
||||
assert cache.bump_cache_epoch() is False
|
||||
|
||||
|
||||
def test_bump_fails_open_when_unreachable(monkeypatch):
|
||||
# An unroutable URL must not raise; the run still succeeds.
|
||||
monkeypatch.setenv("OPENGOODS_REDIS_URL", "redis://127.0.0.1:1/0")
|
||||
assert cache.bump_cache_epoch() is False
|
||||
|
||||
|
||||
def test_bump_increments_epoch(monkeypatch):
|
||||
calls = {}
|
||||
|
||||
class FakeClient:
|
||||
def incr(self, key):
|
||||
calls["key"] = key
|
||||
return 7
|
||||
|
||||
def close(self):
|
||||
calls["closed"] = True
|
||||
|
||||
class FakeRedis:
|
||||
@staticmethod
|
||||
def from_url(url, **kwargs):
|
||||
calls["url"] = url
|
||||
return FakeClient()
|
||||
|
||||
monkeypatch.setitem(sys.modules, "redis", type("M", (), {"Redis": FakeRedis}))
|
||||
|
||||
assert cache.bump_cache_epoch("redis://example:6379/0") is True
|
||||
assert calls["key"] == "og:cache:epoch"
|
||||
assert calls["url"] == "redis://example:6379/0"
|
||||
assert calls["closed"] is True
|
||||
@@ -0,0 +1,2 @@
|
||||
DROP INDEX IF EXISTS idx_product_active_category;
|
||||
DROP INDEX IF EXISTS idx_product_active_quality;
|
||||
@@ -0,0 +1,15 @@
|
||||
-- 检索优化(可扩展性路线图 阶段0):为最常见的"浏览"路径补部分/复合索引。
|
||||
-- 搜索查询恒带 WHERE status = 'active';无关键词时按 quality_score DESC, name 排序。
|
||||
-- 现有索引无法同时满足"过滤 active + 按 quality_score/name 排序",深翻页时需要对全部
|
||||
-- active 行排序。下面的部分复合索引让规划器直接走索引顺序扫描,省掉排序、加速深翻页与
|
||||
-- count(*)。索引只覆盖 active 行,体积更小。
|
||||
|
||||
-- 默认浏览(无关键词、无品类):ORDER BY quality_score DESC, name
|
||||
CREATE INDEX IF NOT EXISTS idx_product_active_quality
|
||||
ON product (quality_score DESC, name)
|
||||
WHERE status = 'active';
|
||||
|
||||
-- 品类内浏览:先按 category_id 收敛,再按 quality_score 排序
|
||||
CREATE INDEX IF NOT EXISTS idx_product_active_category
|
||||
ON product (category_id, quality_score DESC)
|
||||
WHERE status = 'active';
|
||||
@@ -0,0 +1,8 @@
|
||||
-- Reverse 0013: detach products from the seeded drug categories, drop the drug
|
||||
-- category subtree, and remove the drug field template.
|
||||
UPDATE product SET category_id = NULL
|
||||
WHERE category_id IN (SELECT id FROM category WHERE path <@ 'drug');
|
||||
|
||||
DELETE FROM category WHERE path <@ 'drug';
|
||||
|
||||
DELETE FROM kind_field WHERE kind = 'drug';
|
||||
@@ -0,0 +1,43 @@
|
||||
-- Drug (药品) archive kind: a new domain on the generic archive_kind framework
|
||||
-- (see 0010). No new table — drug spec values live in product.attributes JSONB,
|
||||
-- driven by the kind_field template below, plus a 'drug' category subtree.
|
||||
|
||||
-- Field template for the drug domain. field_type is constrained to
|
||||
-- text/number/textarea/select/list by kind_field_type_chk. The `qualified`
|
||||
-- fields are the identifying / regulatory essentials that count toward the
|
||||
-- kind-aware completeness score.
|
||||
INSERT INTO kind_field (kind, field_key, group_label, label_zh, field_type, unit, options, sort_order, qualified) VALUES
|
||||
('drug','approval_number', '基础信息','批准文号', 'text', NULL, '{}', 10, true),
|
||||
('drug','generic_name', '基础信息','通用名', 'text', NULL, '{}', 20, true),
|
||||
('drug','trade_name', '基础信息','商品名', 'text', NULL, '{}', 30, false),
|
||||
('drug','dosage_form', '基础信息','剂型', 'select', NULL, '{片剂,胶囊剂,颗粒剂,散剂,丸剂,注射剂,口服液,糖浆剂,软膏剂,乳膏剂,凝胶剂,滴剂,喷雾剂,气雾剂,栓剂,贴剂,其他}', 40, true),
|
||||
('drug','specification', '基础信息','规格', 'text', NULL, '{}', 50, true),
|
||||
('drug','pack_spec', '基础信息','包装规格', 'text', NULL, '{}', 60, false),
|
||||
('drug','rx_class', '分类与企业','处方分类', 'select', NULL, '{处方药,甲类OTC,乙类OTC}', 70, true),
|
||||
('drug','manufacturer', '分类与企业','生产企业', 'text', NULL, '{}', 80, true),
|
||||
('drug','mah', '分类与企业','上市许可持有人','text', NULL, '{}', 90, false),
|
||||
('drug','indications', '说明书','适应症/功能主治', 'textarea', NULL, '{}', 100, true),
|
||||
('drug','dosage_usage', '说明书','用法用量', 'textarea', NULL, '{}', 110, false),
|
||||
('drug','adverse_reactions', '说明书','不良反应', 'textarea', NULL, '{}', 120, false),
|
||||
('drug','contraindications', '说明书','禁忌', 'textarea', NULL, '{}', 130, false),
|
||||
('drug','precautions', '说明书','注意事项', 'textarea', NULL, '{}', 140, false),
|
||||
('drug','interactions', '说明书','药物相互作用', 'textarea', NULL, '{}', 150, false),
|
||||
('drug','storage', '贮藏与有效期','贮藏', 'text', NULL, '{}', 160, false),
|
||||
('drug','shelf_life', '贮藏与有效期','有效期', 'text', NULL, '{}', 170, false),
|
||||
('drug','spec_source', '贮藏与有效期','说明书来源', 'text', NULL, '{}', 180, false);
|
||||
|
||||
-- Drug category tree. ltree labels are English slugs (no spaces/Chinese);
|
||||
-- Chinese names live in category.name_zh.
|
||||
INSERT INTO category (name_zh, name_en, parent_id, path, level, archive_kind)
|
||||
VALUES ('药品', 'Drug', NULL, 'drug', 0, 'drug');
|
||||
|
||||
INSERT INTO category (name_zh, name_en, parent_id, path, level, archive_kind)
|
||||
SELECT v.name_zh, v.name_en, c.id, v.path::ltree, 1, 'drug'
|
||||
FROM (VALUES
|
||||
('化学药品', 'Chemical drug', 'drug.chemical'),
|
||||
('中成药', 'Chinese patent medicine', 'drug.tcm_patent'),
|
||||
('中药饮片', 'Chinese herbal pieces', 'drug.tcm_herb'),
|
||||
('生物制品', 'Biological product', 'drug.biological'),
|
||||
('疫苗', 'Vaccine', 'drug.vaccine')
|
||||
) AS v(name_zh, name_en, path)
|
||||
JOIN category c ON c.path = 'drug';
|
||||
@@ -0,0 +1 @@
|
||||
9ef4c7d0ea804c11bc637f4e82198e98af908894
|
||||
@@ -1,4 +1,4 @@
|
||||
import type { Category, Product, ProductSummary, SubmissionInput } from "./types";
|
||||
import type { Category, KindField, Product, ProductSummary, SubmissionInput } from "./types";
|
||||
|
||||
async function req<T>(path: string, init?: RequestInit): Promise<T> {
|
||||
const res = await fetch(path, {
|
||||
@@ -67,6 +67,10 @@ export const api = {
|
||||
},
|
||||
product: (id: string) => req<Product>(`/api/v1/products/${id}`),
|
||||
categories: () => req<{ items: Category[] }>(`/api/v1/categories`),
|
||||
kindFields: (kind: string) =>
|
||||
req<{ items: KindField[]; kind: string }>(
|
||||
`/api/v1/kind-fields?kind=${encodeURIComponent(kind)}`,
|
||||
),
|
||||
submit: (input: SubmissionInput) =>
|
||||
req<{ id: string; status: string }>(`/api/public/submissions`, {
|
||||
method: "POST",
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { useEffect, useState } from "react";
|
||||
import { useEffect, useMemo, useState } from "react";
|
||||
import { CheckCircle2, PlusCircle, Trash2 } from "lucide-react";
|
||||
import { api } from "../api";
|
||||
import type { Category, SubmissionImage, SubmissionInput } from "../types";
|
||||
import type { Category, KindField, SubmissionImage, SubmissionInput } from "../types";
|
||||
|
||||
const NUTRI_FIELDS: { key: string; label: string }[] = [
|
||||
{ key: "energy_kcal", label: "能量 (kcal)" },
|
||||
@@ -35,6 +35,8 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
const [ingredients, setIngredients] = useState("");
|
||||
const [basis, setBasis] = useState("");
|
||||
const [nutri, setNutri] = useState<Record<string, string>>({});
|
||||
const [kindFields, setKindFields] = useState<KindField[]>([]);
|
||||
const [attrs, setAttrs] = useState<Record<string, string>>({});
|
||||
const [images, setImages] = useState<SubmissionImage[]>([]);
|
||||
const [imageURL, setImageURL] = useState("");
|
||||
const [submitter, setSubmitter] = useState("");
|
||||
@@ -45,6 +47,33 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
api.categories().then((r) => setCategories(r.items)).catch(() => undefined);
|
||||
}, []);
|
||||
|
||||
// Derive the archive kind from the selected category. No category => generic.
|
||||
const kind = useMemo(() => {
|
||||
const c = categories.find((x) => x.id === categoryID);
|
||||
return c?.archive_kind || "generic";
|
||||
}, [categories, categoryID]);
|
||||
|
||||
// Fetch the kind-specific field template for non-food kinds.
|
||||
useEffect(() => {
|
||||
setAttrs({});
|
||||
if (kind === "food" || kind === "generic") {
|
||||
setKindFields([]);
|
||||
return;
|
||||
}
|
||||
let alive = true;
|
||||
api
|
||||
.kindFields(kind)
|
||||
.then((r) => {
|
||||
if (alive) setKindFields(r.items);
|
||||
})
|
||||
.catch(() => {
|
||||
if (alive) setKindFields([]);
|
||||
});
|
||||
return () => {
|
||||
alive = false;
|
||||
};
|
||||
}, [kind]);
|
||||
|
||||
async function submit(e: React.FormEvent) {
|
||||
e.preventDefault();
|
||||
if (name.trim() === "") {
|
||||
@@ -55,9 +84,31 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
setError("");
|
||||
|
||||
const nutriments: Record<string, number> = {};
|
||||
for (const [k, v] of Object.entries(nutri)) {
|
||||
const n = parseFloat(v);
|
||||
if (!Number.isNaN(n)) nutriments[k] = n;
|
||||
if (kind === "food") {
|
||||
for (const [k, v] of Object.entries(nutri)) {
|
||||
const n = parseFloat(v);
|
||||
if (!Number.isNaN(n)) nutriments[k] = n;
|
||||
}
|
||||
}
|
||||
|
||||
const attributes: Record<string, unknown> = {};
|
||||
if (kind !== "food" && kind !== "generic") {
|
||||
for (const f of kindFields) {
|
||||
const raw = (attrs[f.field_key] || "").trim();
|
||||
if (raw === "") continue;
|
||||
if (f.field_type === "number") {
|
||||
const n = parseFloat(raw);
|
||||
if (!Number.isNaN(n)) attributes[f.field_key] = n;
|
||||
} else if (f.field_type === "list") {
|
||||
const parts = raw
|
||||
.split(/[\n,,、]/)
|
||||
.map((s) => s.trim())
|
||||
.filter((s) => s !== "");
|
||||
if (parts.length) attributes[f.field_key] = parts;
|
||||
} else {
|
||||
attributes[f.field_key] = raw;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
const input: SubmissionInput = {
|
||||
@@ -68,9 +119,10 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
net_content_value: field(netValue) ? parseFloat(netValue) : null,
|
||||
net_content_unit: field(netUnit),
|
||||
country_of_origin: field(country),
|
||||
ingredients_text: field(ingredients),
|
||||
ingredients_text: kind === "food" ? field(ingredients) : null,
|
||||
nutriments: Object.keys(nutriments).length ? nutriments : null,
|
||||
nutrition_basis: basis || null,
|
||||
attributes: Object.keys(attributes).length ? attributes : null,
|
||||
nutrition_basis: kind === "food" && basis ? basis : null,
|
||||
images: images.length ? images : undefined,
|
||||
submitter_name: field(submitter),
|
||||
submitter_contact: field(contact),
|
||||
@@ -107,11 +159,66 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
const input = "input";
|
||||
const label = "block text-xs font-medium text-gray-500 mb-1";
|
||||
|
||||
// Group the kind fields by their group label, preserving template order.
|
||||
const groups: { label: string; fields: KindField[] }[] = [];
|
||||
for (const f of kindFields) {
|
||||
let g = groups.find((x) => x.label === f.group_label);
|
||||
if (!g) {
|
||||
g = { label: f.group_label, fields: [] };
|
||||
groups.push(g);
|
||||
}
|
||||
g.fields.push(f);
|
||||
}
|
||||
|
||||
const KIND_LABEL: Record<string, string> = {
|
||||
drug: "药品",
|
||||
electronics: "数码 3C",
|
||||
food: "食品",
|
||||
generic: "通用",
|
||||
};
|
||||
|
||||
function renderField(f: KindField) {
|
||||
const val = attrs[f.field_key] || "";
|
||||
const set = (v: string) => setAttrs((p) => ({ ...p, [f.field_key]: v }));
|
||||
const lbl = f.unit ? `${f.label_zh} (${f.unit})` : f.label_zh;
|
||||
return (
|
||||
<div key={f.field_key} className={f.field_type === "textarea" || f.field_type === "list" ? "sm:col-span-2" : ""}>
|
||||
<label className={label}>
|
||||
{lbl}
|
||||
{f.qualified && <span className="text-brand-500"> *</span>}
|
||||
</label>
|
||||
{f.field_type === "select" ? (
|
||||
<select className={input} value={val} onChange={(e) => set(e.target.value)}>
|
||||
<option value="">(未选择)</option>
|
||||
{(f.options || []).map((o) => (
|
||||
<option key={o} value={o}>
|
||||
{o}
|
||||
</option>
|
||||
))}
|
||||
</select>
|
||||
) : f.field_type === "textarea" ? (
|
||||
<textarea className={input} rows={3} value={val} placeholder={f.placeholder || ""} onChange={(e) => set(e.target.value)} />
|
||||
) : f.field_type === "list" ? (
|
||||
<textarea className={input} rows={2} value={val} placeholder={f.placeholder || "每行一项,或用、逗号分隔"} onChange={(e) => set(e.target.value)} />
|
||||
) : (
|
||||
<input
|
||||
type={f.field_type === "number" ? "number" : "text"}
|
||||
step={f.field_type === "number" ? "any" : undefined}
|
||||
className={input}
|
||||
value={val}
|
||||
placeholder={f.placeholder || ""}
|
||||
onChange={(e) => set(e.target.value)}
|
||||
/>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<form onSubmit={submit} className="max-w-3xl mx-auto animate-fade-up">
|
||||
<h1 className="text-2xl font-semibold tracking-tight text-gray-900">贡献商品档案</h1>
|
||||
<p className="mt-1 text-sm text-gray-500">
|
||||
任何人都可以提交新商品资料。提交后会进入审核队列,<b>通过人工审核后才会收纳</b>。带 * 为必填。
|
||||
任何人都可以提交新商品资料。提交后会进入审核队列,<b>通过人工审核后才会收纳</b>。除商品名称外均为选填,按品类填写对应资料即可。
|
||||
</p>
|
||||
|
||||
{error && (
|
||||
@@ -143,6 +250,11 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
</option>
|
||||
))}
|
||||
</select>
|
||||
{categoryID && (
|
||||
<p className="mt-1 text-xs text-gray-400">
|
||||
档案类型:{KIND_LABEL[kind] || kind}
|
||||
</p>
|
||||
)}
|
||||
</div>
|
||||
<div>
|
||||
<label className={label}>产地</label>
|
||||
@@ -165,39 +277,56 @@ export default function Contribute({ onDone }: { onDone: () => void }) {
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<div className="card p-5 mt-4">
|
||||
<h2 className="font-medium text-gray-700 mb-3">配料与营养</h2>
|
||||
<label className={label}>配料表</label>
|
||||
<textarea
|
||||
className={input}
|
||||
rows={3}
|
||||
value={ingredients}
|
||||
onChange={(e) => setIngredients(e.target.value)}
|
||||
/>
|
||||
<div className="mt-3">
|
||||
<label className={label}>营养基准</label>
|
||||
<select className={input} value={basis} onChange={(e) => setBasis(e.target.value)}>
|
||||
<option value="">(未设置)</option>
|
||||
<option value="per_100g">每 100g</option>
|
||||
<option value="per_100ml">每 100ml</option>
|
||||
<option value="per_serving">每份</option>
|
||||
</select>
|
||||
{kind === "food" && (
|
||||
<div className="card p-5 mt-4">
|
||||
<h2 className="font-medium text-gray-700 mb-3">配料与营养</h2>
|
||||
<label className={label}>配料表</label>
|
||||
<textarea
|
||||
className={input}
|
||||
rows={3}
|
||||
value={ingredients}
|
||||
onChange={(e) => setIngredients(e.target.value)}
|
||||
/>
|
||||
<div className="mt-3">
|
||||
<label className={label}>营养基准</label>
|
||||
<select className={input} value={basis} onChange={(e) => setBasis(e.target.value)}>
|
||||
<option value="">(未设置)</option>
|
||||
<option value="per_100g">每 100g</option>
|
||||
<option value="per_100ml">每 100ml</option>
|
||||
<option value="per_serving">每份</option>
|
||||
</select>
|
||||
</div>
|
||||
<div className="grid grid-cols-2 sm:grid-cols-4 gap-3 mt-3">
|
||||
{NUTRI_FIELDS.map((f) => (
|
||||
<div key={f.key}>
|
||||
<label className={label}>{f.label}</label>
|
||||
<input
|
||||
type="number"
|
||||
step="any"
|
||||
className={input}
|
||||
value={nutri[f.key] || ""}
|
||||
onChange={(e) => setNutri({ ...nutri, [f.key]: e.target.value })}
|
||||
/>
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
<div className="grid grid-cols-2 sm:grid-cols-4 gap-3 mt-3">
|
||||
{NUTRI_FIELDS.map((f) => (
|
||||
<div key={f.key}>
|
||||
<label className={label}>{f.label}</label>
|
||||
<input
|
||||
type="number"
|
||||
step="any"
|
||||
className={input}
|
||||
value={nutri[f.key] || ""}
|
||||
onChange={(e) => setNutri({ ...nutri, [f.key]: e.target.value })}
|
||||
/>
|
||||
)}
|
||||
|
||||
{kind !== "food" && kind !== "generic" && kindFields.length > 0 && (
|
||||
<div className="card p-5 mt-4">
|
||||
<h2 className="font-medium text-gray-700 mb-1">{KIND_LABEL[kind] || kind}资料</h2>
|
||||
<p className="text-xs text-gray-400 mb-3">带 * 为该品类的关键字段,建议尽量填写。</p>
|
||||
{groups.map((g) => (
|
||||
<div key={g.label} className="mt-3 first:mt-0">
|
||||
{g.label && <h3 className="text-xs font-semibold text-gray-400 mb-2">{g.label}</h3>}
|
||||
<div className="grid grid-cols-1 sm:grid-cols-2 gap-4">
|
||||
{g.fields.map(renderField)}
|
||||
</div>
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
<div className="card p-5 mt-4">
|
||||
<h2 className="font-medium text-gray-700 mb-3">图片(仅填 URL)</h2>
|
||||
|
||||
@@ -51,6 +51,20 @@ export interface Category {
|
||||
name_en: string | null;
|
||||
path: string;
|
||||
level: number;
|
||||
archive_kind: string;
|
||||
}
|
||||
|
||||
export interface KindField {
|
||||
kind: string;
|
||||
field_key: string;
|
||||
group_label: string;
|
||||
label_zh: string;
|
||||
field_type: "text" | "number" | "textarea" | "select" | "list";
|
||||
unit: string | null;
|
||||
options: string[] | null;
|
||||
placeholder: string | null;
|
||||
sort_order: number;
|
||||
qualified: boolean;
|
||||
}
|
||||
|
||||
export interface SubmissionImage {
|
||||
@@ -68,6 +82,7 @@ export interface SubmissionInput {
|
||||
country_of_origin?: string | null;
|
||||
ingredients_text?: string | null;
|
||||
nutriments?: Record<string, number> | null;
|
||||
attributes?: Record<string, unknown> | null;
|
||||
nutrition_basis?: string | null;
|
||||
serving_size?: string | null;
|
||||
nutri_score?: string | null;
|
||||
|
||||
Reference in New Issue
Block a user